Original PR is here - davidblasby#1

(reviewed by @josegar74 )

@fxprunayre - would love to talk to you about this during the sprint this week.

added 2 commits;

1. update CORS to allow connections
   This shouldnt be a problem because the ogcapi is all GET-based (readonly)
2. add collection (catalog/sub-portal) icon

@josegar74 @fxprunayre @f-necas I'd like to merge this is this week. I'm working on Queryables and Search right now (#116), and want to finish this up.

There is a Sonar warning - this is because I set the CORS so the ogcapi-records is accessible as a service. They are all GETs at the moment, so i don't think this is too big an issue.

@davidblasby If the metadata has online resources, the geojson output fails with 406 error. for example with the sample metadata Hydrological Basins in Africa (Sample record, please remove!)

http://localhost:9901/collections/main/items/da165110-88fd-11da-a88f-000d939bc5d8

I see in the log:

com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: Unrecognized field "hash" (class org.fao.geonet.index.model.gn.Link), not marked as ignorable (9 known properties: "nilReason", "protocol", "applicationProfile", "nameObject", "descriptionObject", "mimeType", "group", "function", "urlObject"])
 at [Source: (String)"{
  "docType" : "metadata",
  "document" : "",
  "metadataIdentifier" : "da165110-88fd-11da-a88f-000d939bc5d8",

Apparently some issue with the index model in GeoNetwork adn the class that models links in this project.

Recently was added a hash property in the links.

@davidblasby to solve this issue, please update https://github.com/geonetwork/geonetwork-microservices/blob/main/modules/library/common-index-model/src/main/java/org/fao/geonet/index/model/gn/Link.java

And add:

  private String hash;
  private String idx;

About

4. Landing page (/)
The landing page JSON also includes a new property systemInfo which contains a catalog.yaml object in it.
I'm not sure if this is allowed in the spec, but it allows for more metadata about the entire GN system ("ogcapi-records" server). This is useful for making a nicer landing page (cf. pygeoapi's landing page).

You mean that pygeoapi's uses this systemInfo also? or it's completely custom to GeoNetwork implementation?

We should check if there is a validator available, but last time I checked some months ago, that was not the case.

You mean that pygeoapi's uses this systemInfo also? or it's completely custom to GeoNetwork implementation?

No - Its unclear where pygeoapi gets its information from (its not in its JSON output).
there is no systeminfo inside pygeoapi. I just added it so an external (i.e. angular) app would have access to this info.

@josegar74 - added the hash/idx.

I updated this to use the parsed IndexRecord instead directly from the elastic index json.

This is in prep for GeoJSON changes.

Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

@josegar74 @fxprunayre - will merge this tomorrow.

Sounds fine to add this @davidblasby. There is some issues
http://localhost:9901/collections/inspire?f=json will return service info
http://localhost:9901/collections/inspire?f=xml will not (related to getRecordAsJson and request headers) but for demo purpose that can be ok.

Also we should plan to move it to GeoNetwork 5 codebase at some point

@fxprunayre - I havent been looking at the XML output - just the JSON. I will put that on the list!

Whats involved with moving to the GN5 codebase? I don't know anything about it...

@fxprunayre - I havent been looking at the XML output - just the JSON. I will put that on the list!

Not urgent.

Whats involved with moving to the GN5 codebase? I don't know anything about it...

We are cleaning up the POC with @josegar74 and we will move the repository to GeoNetwork organisation as discussed in Bennekom. Then we can look into it.